Fix reference to k8s homedir package#226
Closed
erikh wants to merge 1 commit intocontainers:masterfrom
Closed
Conversation
Signed-off-by: Erik Hollensbe <[email protected]>
Contributor
Author
|
Sorry I didn't see #225, if the k8s lib is still required feel free to close this. |
giuseppe
pushed a commit
to giuseppe/image
that referenced
this pull request
Jan 24, 2017
vendor containers/image
Collaborator
Contributor
Author
|
If you want, I could make the changes to storage to accommodate the k8s
homedir needs so we only have one dep.
…On Tue, Jan 24, 2017 at 6:56 AM Miloslav Trmač ***@***.***> wrote:
Yeah, it would be nice to use a single package; sadly, the two have a bit
different semantics. #225 <#225>
tries to preserve the k8s semantics, but we’ll see whether that is
acceptable for #207 <#207>.
So let’s keep this open for a bit. Thanks for working on this!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#226 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABJ6-QqE3qGJcgkgpJ_eDWN9eKdUP3nks5rVhEfgaJpZM4Lr88Z>
.
|
Collaborator
|
At this point it seems preferable for the OpenShift transport to clearly use OpenShift semantics, and for containers/storage to clearly use container/storage semantics, whatever they are and however they differ (or not). Unifying the dependency would be nice in principle, but honestly the packages are small enough that not having to think about how they differ from the respective upstreams and whether/why that matters is simpler. (And they do matter somehow, otherwise everyone would just be doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch just replaces the k8s library with the one in
opencontainers/storage. Tests still pass and we can just fix that much easier
if we need to.